ChanServ changed the topic of #asahi-dev to: Asahi Linux: porting Linux to Apple Silicon macs | Non-development talk: #asahi | General development | GitHub: https://alx.sh/g | Wiki: https://alx.sh/w | Logs: https://alx.sh/l/asahi-dev
pb17 has quit [Ping timeout: 480 seconds]
pb17 has joined #asahi-dev
mushisaaa has quit [Quit: mushisaaa]
KxCORP589 has quit [Quit: Bye!]
KxCORP589 has joined #asahi-dev
john-cabaj has quit [Ping timeout: 480 seconds]
xal has quit []
xal has joined #asahi-dev
mushisaaa has joined #asahi-dev
mushisaaa has quit [Quit: mushisaaa]
mushisaaa has joined #asahi-dev
jeisom has quit [Ping timeout: 480 seconds]
DarkShadow44 has joined #asahi-dev
DarkShadow4444 has quit [Ping timeout: 480 seconds]
ddxtanx has quit [Quit: Konversation terminated!]
mushisaaa has quit [Quit: mushisaaa]
<chadmed>
jannau: macsmc_hwmon_read_key is not valid c11, so idk if we can keep it
<chadmed>
gcc doesnt complain but clang emits a warning
<chadmed>
easiest way to make it shut up would be to go back to declaring all the key types we support at the top of the function, as annoying as that is
mushisaaa has joined #asahi-dev
<chadmed>
if we're only needing to support 'flt ' and 'ioft' then its fine imo
<leio>
that diff doesn't match the code I'm looking at from jannau's branch
<leio>
where there is a block after case label
<leio>
case _SMC_KEY("flt "): {
<chadmed>
oh duh put it in a block
<leio>
line number is like 20 off as well
<chadmed>
yeah of course it is i rewrote parts of the driver and this version has no fan support because im not up to that yet
<chadmed>
i still dont think we should allow the setting of fan speeds even behind a parameter btw
<chadmed>
look at how many people ignored the repeated warnings about prematurely enabling their speakers
<chadmed>
we cannot guarantee that messing with the fan settings is safe yet so we should not allow it to be done in production systems at all until we can
<jannau>
I'm not proposing to merge that version. there is a legitimate development use for fan speed control. It makes CPU core temp key mapping easier